Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper colors on selected-indeterminate and non-selected in clipboard #4691

Conversation

nucleogenesis
Copy link
Member

Summary

Description of the change(s) you made

  • Adds /deep/ selectors and such for applying a particular color to the KCheckbox in the Clipboard when it is in the unique-to-the-Clipboard "selected + indeterminate" state vs "just indeterminate".
  • The difference between these states are that when "selected + indeterminate", the indeterminate checkbox is blue, indicating that it is included in the user's overall selection.
  • When it is only indeterminate, it is gray, indicating that it is not included in the selection.

Screenshots (if applicable)

2024-08-29.12-46-25.mp4

Does this introduce any tech-debt items

/deep/ selectors are hacky and if we need this pattern again in the future, it will need to handle this directly.


Reviewer guidance

How can a reviewer test these changes?

How's the screencast look?

This PR does not include it, but to test this locally you need to point your package.json entry for KDS to use this PR in KDS.

References

Closes #4636

Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes makes sense to me, and manual QA suggest everything is working fine. Thank you @nucleogenesis! I think the only thing left to do is to update the KDS version once the new version has been released =)

@nucleogenesis nucleogenesis mentioned this pull request Sep 3, 2024
@nucleogenesis nucleogenesis force-pushed the fix--clipbaord-checkboxes-and-numbers branch from de2efaa to 8c717d0 Compare September 10, 2024 15:10
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @nucleogenesis

@akolson akolson merged commit e0d2ab9 into learningequality:unstable Sep 12, 2024
13 checks passed
@akolson akolson mentioned this pull request Sep 13, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clipboard indeterminate selection incorrect
3 participants