Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update account deletion string #4607

Conversation

marcellamaki
Copy link
Member

Summary

Description of the change(s) you made

Updates string to more accurately display the current (if not ideal) behavior for account deletion with shared channels.

Manual verification steps performed

Create a brand new account
Create a channel and share it with someone so that they can edit it.
Go to Settings > Account and attempt to delete the account. See updated warning string.

Screenshots (if applicable)

image

Does this introduce any tech-debt items?

No, but it doesn't resolve the underlying problem, either


Reviewer guidance

How can a reviewer test these changes?

Reference manual verification steps above.

References

Sort of fixes #4532 , at least as much as we can right now.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@@ -197,7 +197,7 @@
completelyDeleteAccountLabel: 'Completely remove your account from Kolibri Studio',
unableToDeleteAdminAccount: 'Unable to delete an admin account',
handleChannelsBeforeAccount:
'You must delete these channels manually or invite others to edit them before you can delete your account.',
'You cannot delete accounts that have shared channels. You must delete these channels manually before you can delete your account.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could say that they cannot delete accounts that have channels (in general), not specifically shared channels because even if they have not shared them, they still cannot delete the account.

@marcellamaki marcellamaki force-pushed the update-shared-channel-deletion-string branch from b64c101 to c368ac8 Compare July 29, 2024 14:48
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcellamaki marcellamaki merged commit eca7298 into learningequality:unstable Jul 30, 2024
13 checks passed
@akolson akolson mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings - Cannot delete an account with 1 shared channel
3 participants