Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio usability enhancements #4461

Open
wants to merge 130 commits into
base: unstable
Choose a base branch
from

Conversation

AlexVelezLl
Copy link
Member

@AlexVelezLl AlexVelezLl commented Feb 29, 2024

Summary

Description of the change(s) you made

This PR introduces the new Studio Usabiliy enhancements project:

  • We now allow quick editing of the following fields of one or more resources and folders:

    • Title and description (bulk editing not supported).
    • Language.
    • Categories.
    • Levels.
    • Needed Resources.
  • And editing the following fields of one or more resources:

    • Audience.
    • Source.
    • Learning Activities.
    • Completion (bulk editing not supported).
  • Bulk editing of folder descendants, so that if the user is editing any field in a folder, they can choose to replicate the change to all of its descendants.

  • New command palette arrangement, with responsive design.

Screenshots (if applicable)

Editing single resources:

Compartir.pantalla.-.2024-03-01.09_03_50.mp4

Editing multiple resources and topics:

Compartir.pantalla.-.2024-03-01.09_06_15.mp4

Does this introduce any tech-debt items?

A drawback is that we are now having two parallel editing logic for some of the fields which can be a problem in the future.


Reviewer guidance

How can a reviewer test these changes?

  • Go and edit any channel
  • You can edit the fields of a single resource/folder clicking on the kebab menu
  • You can select multiple resources/folders and test actions in the command palette

Are there any risky areas that deserve extra testing?

  • Offline syncing of descendants edit in bulk.

References

Addresses #3412


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@AlexVelezLl AlexVelezLl force-pushed the studio-usability-enhancements branch from faa94f7 to 473c8ba Compare March 8, 2024 17:43
@MisRob MisRob removed their request for review March 12, 2024 09:19
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it's looking good. I'm wondering if it's worth deduping some of 'Save' / 'Cancel' strings. I think we have some mixins that might have the strings? We did have a retrospective last year and decided on an approach for reusing strings but I can't quite recall what we decided.

I'll give it a test drive soon!

@bjester
Copy link
Member

bjester commented Mar 29, 2024

I ran into this bug, both in unstable and this branch #4493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants