Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement minimum length for passwords in account creation #4353

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Implement minimum length for passwords in account creation #4353

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e25e153
password validation implemented in frontend
cerdo03 Dec 8, 2023
88d3527
Update contentcuration/contentcuration/frontend/accounts/pages/Create…
cerdo03 Dec 13, 2023
3c2670a
changes suggested by maintainers
cerdo03 Dec 14, 2023
e76340e
changes suggested by maintainers
cerdo03 Dec 14, 2023
ee4dd20
conflicts resolved
cerdo03 Dec 14, 2023
e1ab67c
testing changes
cerdo03 Dec 16, 2023
2837390
Merge branch 'unstable' of github.com:cerdo03/studio into password-va…
cerdo03 Dec 17, 2023
e81026d
Cleanup registration form handling
bjester Feb 16, 2024
91af8c0
Consolidate 'This field is required' and handle registration form res…
bjester Feb 16, 2024
4d2f325
Update frontend test for create page changes
bjester Feb 16, 2024
8987146
Merge unstable
AlexVelezLl Aug 9, 2024
fca4046
Fix test
AlexVelezLl Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions contentcuration/contentcuration/frontend/accounts/pages/Create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
<PasswordField
v-model="form.password1"
:label="$tr('passwordLabel')"
:additionalRules="passwordValidationRules"
/>
<PasswordField
v-model="form.password2"
Expand Down Expand Up @@ -241,6 +242,9 @@
passwordConfirmRules() {
return [value => (this.form.password1 === value ? true : this.$tr('passwordMatchMessage'))];
},
passwordValidationRules() {
return [value =>(this.form.password1.length >= 8 ? true : this.$tr('passwordValidationMessage'))];

Check failure on line 246 in contentcuration/contentcuration/frontend/accounts/pages/Create.vue

View workflow job for this annotation

GitHub Actions / Frontend linting 

'value' is defined but never used
bjester marked this conversation as resolved.
Show resolved Hide resolved
},
tosAndPolicyRules() {
return [value => (value ? true : this.$tr('ToSRequiredMessage'))];
},
Expand Down Expand Up @@ -465,6 +469,7 @@
passwordLabel: 'Password',
confirmPasswordLabel: 'Confirm password',
passwordMatchMessage: "Passwords don't match",
passwordValidationMessage: "Password should be atleast 8 characters long",
cerdo03 marked this conversation as resolved.
Show resolved Hide resolved

// Usage question
usageLabel: 'How do you plan on using Kolibri Studio (check all that apply)',
Expand Down