-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation to extract metadata from H5P Content Package #4131
Implementation to extract metadata from H5P Content Package #4131
Conversation
- implement code to extract .h5p files metadata;
e8c0173
to
7b4608c
Compare
c7bb7f3
to
3a2b734
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in the future we may want to distinguish between the file metadata and the node metadata specifically, but for now, I think this will work.
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
- override file title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little bit of code cleanup, and just need a test to give us some assurance here and it should be good to go.
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/components/edit/EditModal.vue
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tweaks in the tests, but this is looking ready to go!
contentcuration/contentcuration/frontend/shared/vuex/file/__tests__/module.spec.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/utils.js
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/shared/vuex/file/__tests__/module.spec.js
Outdated
Show resolved
Hide resolved
- [lint] fixes
5350a65
to
3f68c51
Compare
This code aims to extract metadata from H5P content package.
This Pr is a part of GSoC Project linked with the issue #4081.
Summary
Description of the change(s) you made
getH5PMetadata
Manual verification steps performed
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)