Skip to content

Conversation

@JanaKocakova
Copy link

Summary

This PR migrates the two dialogs in SavedSearchesModal from Vuetify components to KDS:

  • Replaced MessageDialog with KModal for delete confirmation dialog
  • Replaced ActionLink with KRouterLink for saved search links
  • Replaced VList, VListTile* components with semantic HTML (<ul>, <li>, <div>) and custom SCSS
  • Replaced VDivider with CSS border-bottom styling
  • Added notranslate class to user-generated search names to prevent Chrome auto-translation
  • No logic changed - all methods, computed properties, and data remain unchanged.

Manual verification performed:

  • Verified saved searches list displays correctly with proper spacing and styling
  • Clicked saved search link - navigates to results and closes modal
  • Tested delete flow - delete works
  • Verified empty state message displays when no saved searches exist
  • Tested keyboard navigation on links and buttons
  • I provide screenshots before and after for Saved searches dialog, empty saved searches dialog and Delete search dialog. Firstly is "before screenshot" and later is "after screenshot":
BeforeSavedSearches AfterSavedSearches BeforeSavedSearchesEmpty AfterSavedSearchesEmpty BeforeDeleteSearch AfterDeleteSearch

References

Parent issue - #5060)

Reviewer guidance

  • I didnt add unit tests as this change is a UI-only migration with no logic changes, and this view previously had no test coverage. I considered adding unit tests but I think that manual testing while doing screenshots is the best way to capture possible user interactions.
  • I wasnt sure how should i define color for text, but I tried to follow existing examples using for example "color: var(--v-grey-base);"
  • You can see difference in before and after screenshot for Delete search dialog. Originally behind this dialog was no backdrop/scrim even though there was backdrop behind Saved searches dialog. I left backdrop there as it looks like default KModal behavior.

@learning-equality-bot
Copy link

👋 Thanks for contributing!

We will assign a reviewer within the next two weeks. In the meantime, please ensure that:

  • You ran pre-commit locally
  • All issue requirements are satisfied
  • The contribution is aligned with our Contributing guidelines. Pay extra attention to Using generative AI. Pull requests that don't follow the guidelines will be closed.

We'll be in touch! 😊

@learning-equality-bot
Copy link

Season’s greetings! 👋

We’d like to thank everyone for another year of fruitful collaborations, engaging discussions, and for the continued support of our work. Learning Equality will be on holidays from December 22 to January 5. We look forward to much more in the new year and wish you a very happy holiday season!

Are you preparing for Google Summer of Code? See our GSoC guidelines.

@MisRob MisRob self-requested a review December 16, 2025 16:05
@MisRob MisRob self-assigned this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants