Implement minimum length for passwords in account creation #4353

cerdo03 · 2023-12-08T07:28:47Z

Summary

Description of the change(s) you made

Fixes #4142
I have implemented password length validation on password1 field. Password should be at least 8 characters long otherwise it would throw an error that "Password should be atleast 8 characters long".

Manual verification steps performed

Go the the create account page
If the password that you enter is smaller than 8 characters, it will show an error.

Comments

Does the validation need to implemented on backend as well?

Contributor's Checklist

PR process:

If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
If this includes an internal dependency change, a link to the diff is provided
The docs label has been added if this introduces a change that needs to be updated in the user docs?
If any Python requirements have changed, the updated requirements.txt files also included in this PR
Opportunities for using Google Analytics here are noted
Migrations are safe for a large db

Studio-specifc:

All user-facing strings are translated properly
The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
All UI components are LTR and RTL compliant
Views are organized into pages, components, and layouts directories as described in the docs
Users' storage used is recalculated properly on any changes to main tree files
If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

Code is clean and well-commented
Contributor has fully tested the PR manually
If there are any front-end changes, before/after screenshots are included
Critical user journeys are covered by Gherkin stories
Any new interactions have been added to the QA Sheet
Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

Automated test coverage is satisfactory
PR is fully functional
PR has been tested for accessibility regressions
External dependency files were updated if necessary (yarn and pip)
Documentation is updated
Contributor is in AUTHORS.md

akolson

Hi @cerdo03! Generally the code looks good and works as expected, thanks. However it appears that one of the scenarios specified on the issue will fail

.....In development mode, the password a should still work.

@bjester will clarify on this.

Also, noting that there are a few failing tests that will need fixing before a merge.

contentcuration/contentcuration/frontend/accounts/pages/Create.vue

….vue Co-authored-by: Blaine Jester <[email protected]>

…lidation-surya

bjester

I see some print statements and a lot of commented code.

MisRob · 2024-02-15T11:29:04Z

Hello @cerdo03, are you still planning to follow-up here or would it be better to close the pull request?

…ponses

bjester · 2024-02-16T18:56:20Z

@cerdo03 Thank you for taking this on. You got it most of the way there, and I wrapped it up. Some of the backend code was quite confusing in how it worked.

stale

akolson · 2024-02-26T10:16:06Z

contentcuration/contentcuration/frontend/accounts/pages/Create.vue

@@ -291,10 +310,12 @@
        ];
      },
      usageRules() {
-        return [() => (this.form.uses.length ? true : this.$tr('fieldRequiredMessage'))];
+        /* eslint-disable-next-line kolibri/vue-no-undefined-string-uses */


I think this is nolonger necessary as fieldRequired exists. There's a few other places to clean this up too.

Unfortunately, this is required. The linting rule does not properly understand this is an external translator

akolson

Generally, the implemenation looks correct to me. There seem to be a few linting comments that may require cleanup too. Unless it is deliberate to have them, we should be good to go. Also, the failing test needs to be looked into before the merge.

akolson · 2024-08-01T13:58:20Z

Hi @cerdo03! Are you still interested in contributing to this pr, or we should reassign it?

akolson

Generally, the implementation looks correct to me. Manual QA also checkouts. However, it looks like

In development mode, the password a should still work.

is still missing. @bjester is still a requirement for this pr?

bjester · 2024-08-12T19:33:32Z

Generally, the implementation looks correct to me. Manual QA also checkouts. However, it looks like

In development mode, the password a should still work.

is still missing. @bjester is still a requirement for this pr?

My comment there was a bit ambiguous. I meant that it should still work for login. That should still be the case

akolson

@AlexVelezLl adding a little blocker so that the issue here can be address too!

bjester · 2024-08-13T14:10:06Z

@AlexVelezLl adding a little blocker so that the issue here can be address too!

@akolson I just tested this and the [email protected] + a login is working. There should be no blockers?

akolson

Approving this after a chat with Blaine. The context of this was based on how historical data should be handled, and the pr addresses this. Thanks again @AlexVelezLl for finishing this off!

password validation implemented in frontend

e25e153

MisRob requested review from bjester and akolson December 8, 2023 08:46

MisRob added the TODO: needs review label Dec 8, 2023

akolson reviewed Dec 12, 2023

View reviewed changes

contentcuration/contentcuration/frontend/accounts/pages/Create.vue Outdated Show resolved Hide resolved

bjester reviewed Dec 13, 2023

View reviewed changes

contentcuration/contentcuration/frontend/accounts/pages/Create.vue Outdated Show resolved Hide resolved

cerdo03 and others added 6 commits December 13, 2023 22:30

Update contentcuration/contentcuration/frontend/accounts/pages/Create…

88d3527

….vue Co-authored-by: Blaine Jester <[email protected]>

changes suggested by maintainers

3c2670a

changes suggested by maintainers

e76340e

conflicts resolved

ee4dd20

testing changes

e1ab67c

Merge branch 'unstable' of github.com:cerdo03/studio into password-va…

2837390

…lidation-surya

bjester added the TAG: user strings label Dec 19, 2023

bjester self-requested a review January 10, 2024 18:19

bjester previously requested changes Jan 10, 2024

View reviewed changes

rtibbles assigned bjester Jan 16, 2024

bjester added 2 commits February 16, 2024 10:51

Cleanup registration form handling

e81026d

Consolidate 'This field is required' and handle registration form res…

91af8c0

…ponses

bjester requested review from rtibbles, akolson and bjester February 16, 2024 18:56

Update frontend test for create page changes

4d2f325

bjester changed the title ~~password validation implemented in frontend~~ Implement minimum length for passwords in account creation Feb 16, 2024

akolson reviewed Feb 26, 2024

View reviewed changes

akolson self-assigned this Aug 1, 2024

akolson unassigned bjester Aug 1, 2024

AlexVelezLl added 2 commits August 9, 2024 11:07

Merge unstable

8987146

Fix test

fca4046

AlexVelezLl requested a review from akolson August 12, 2024 15:28

akolson reviewed Aug 12, 2024

View reviewed changes

akolson requested changes Aug 12, 2024

View reviewed changes

bjester requested a review from akolson August 13, 2024 14:10

akolson approved these changes Aug 13, 2024

View reviewed changes

akolson merged commit e01dcb5 into learningequality:unstable Aug 13, 2024
13 checks passed

akolson mentioned this pull request Aug 13, 2024

Bulk Edit Release #4635

Merged

akolson mentioned this pull request Oct 1, 2024

Release v2024.10.02 #4776

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement minimum length for passwords in account creation #4353

Implement minimum length for passwords in account creation #4353

cerdo03 commented Dec 8, 2023

akolson left a comment •

edited

Loading

bjester left a comment

MisRob commented Feb 15, 2024

bjester commented Feb 16, 2024

akolson Feb 26, 2024 •

edited

Loading

bjester Feb 26, 2024

akolson left a comment •

edited

Loading

akolson commented Aug 1, 2024

akolson left a comment

bjester commented Aug 12, 2024

akolson left a comment

bjester commented Aug 13, 2024

akolson left a comment •

edited

Loading

Implement minimum length for passwords in account creation #4353

Implement minimum length for passwords in account creation #4353

Conversation

cerdo03 commented Dec 8, 2023

Summary

Description of the change(s) you made

Manual verification steps performed

Comments

Contributor's Checklist

Reviewer's Checklist

This section is for reviewers to fill out.

akolson left a comment • edited Loading

Choose a reason for hiding this comment

bjester left a comment

Choose a reason for hiding this comment

MisRob commented Feb 15, 2024

bjester commented Feb 16, 2024

akolson Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

bjester Feb 26, 2024

Choose a reason for hiding this comment

akolson left a comment • edited Loading

Choose a reason for hiding this comment

akolson commented Aug 1, 2024

akolson left a comment

Choose a reason for hiding this comment

bjester commented Aug 12, 2024

akolson left a comment

Choose a reason for hiding this comment

bjester commented Aug 13, 2024

akolson left a comment • edited Loading

Choose a reason for hiding this comment

akolson left a comment •

edited

Loading

akolson Feb 26, 2024 •

edited

Loading

akolson left a comment •

edited

Loading

akolson left a comment •

edited

Loading