fixes the route #12441
Merged
fixes the route #12441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AllanOXDi
force-pushed
the
EQM-missing-model
branch
from
18ddb74
to
58d0f98
Compare
AllanOXDi
requested review from
rtibbles and
nucleogenesis
and removed request for
rtibbles
nucleogenesis
requested changes
Jul 12, 2024
Comment on lines
409
to
413
| if (nextRoute.name === PageNames.EXAM_CREATION_ROOT) { | ||
| this.$router.push(nextRoute); | ||
| } else { | ||
| this.$router.replace(nextRoute); | ||
| } |
There was a problem hiding this comment.
@AllanOXDi I think we should remove this and test as I don't think it really helps us.
AllanOXDi
force-pushed
the
EQM-missing-model
branch
from
862badc
to
9fb2414
Compare
AllanOXDi
force-pushed
the
EQM-missing-model
branch
from
2811337
to
27019b5
Compare
nucleogenesis
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Changes look great thank you @AllanOXDi - tested locally and all worked well. I'll merge this shortly
nucleogenesis
merged commit 2fa688c
into
learningequality:release-v0.17.x
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes the missing confirmation modal when the browser back button is clicked
Screen.Recording.2024-07-13.at.01.05.27.mov
References
#12421
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarnandpip)