Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO_NOT_MERGE_ONLY_FOR_QA KRadioButtonGroup testing #12325

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

muditchoudhary
Copy link
Contributor

@muditchoudhary muditchoudhary commented Jun 20, 2024

Summary

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: medium labels Jun 20, 2024
@muditchoudhary
Copy link
Contributor Author

Hi @pcenov @radinamatic could you please QA test now? I fixed the tab issue on the change language modal.

cc: @MisRob

@MisRob
Copy link
Member

MisRob commented Jun 20, 2024

Thanks @muditchoudhary!

For QA, test instructions are written here #12243

@pcenov
Copy link
Member

pcenov commented Jun 21, 2024

Thanks a lot @muditchoudhary!
@radinamatic I confirm that tab navigation through the radio buttons in the language modal is working correctly in Firefox:

2024-06-21_13-32-03.mp4

@muditchoudhary
Copy link
Contributor Author

Thank you @pcenov

@MisRob MisRob self-requested a review July 9, 2024 17:10
@MisRob MisRob self-assigned this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants