Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow redirects for file downloads #12309

Open
wants to merge 1 commit into
base: release-v0.17.x
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

Summary

  • Development Studio uses redirects to expose resources and content databases
  • Our current file download logic does not handle these properly
  • Updates this to handle this properly!

References

Fixes issue first reported here: learningequality/studio#4416 (comment)

Reviewer guidance

Try to import channels/resources from a local Studio instance - see that it works!


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Jun 18, 2024
@rtibbles rtibbles added this to the Kolibri 0.17: Planned Patch 1 milestone Jul 1, 2024
@rtibbles rtibbles changed the base branch from develop to release-v0.17.x July 12, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant