Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix topic header tests #11535

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix topic header tests #11535

merged 1 commit into from
Nov 16, 2023

Conversation

nucleogenesis
Copy link
Member

Summary

Tests failing causing PRs based on develop to fail. The changes reflect how the code under test works.

Reviewer guidance

Do the tests pass? Changes okay?

@nucleogenesis nucleogenesis added the TODO: needs review Waiting for review label Nov 16, 2023
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Nov 16, 2023
@github-actions GitHub Actions
Copy link
Contributor

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.0b6.dev0_git.518.g7056b4d4.pex
Windows Installer (EXE) kolibri-0.16.0b6.dev0+git.518.g7056b4d4-unsigned.exe
Debian Package kolibri_0.16.0b6.dev0+git.518.g7056b4d4-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.0b6.dev0+git.518.g7056b4d4-0.3.0.dmg
Android Package (APK) kolibri-0.16.0b6.dev0+git.518.g7056b4d4-0.1.0-debug.apk
TAR file kolibri-0.16.0b6.dev0+git.518.g7056b4d4.tar.gz
WHL file kolibri-0.16.0b6.dev0+git.518.g7056b4d4-py2.py3-none-any.whl

@nucleogenesis nucleogenesis mentioned this pull request Nov 16, 2023
Merged
9 tasks
rtibbles
rtibbles approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches up to the actual conditions that are used to conditionalize the template.

@rtibbles rtibbles merged commit 6250574 into learningequality:develop Nov 16, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@AllanOXDi AllanOXDi Awaiting requested review from AllanOXDi

Assignees
No one assigned
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nucleogenesis @rtibbles