Pressing enter to submit the Super Admin creation form in the Setup Wizard and show form validation error #11465 #11500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Artifacts
|
|
Hi @a6ar55 , thank you for your contribution! We will definitely follow-up, there's been lots of pull requests in our queue. |
jredrejo
reviewed
Nov 10, 2023
| } else { | ||
| // Blurring will cause validation errors to show if needed | ||
| e.target.blur(); | ||
| if (e.key === 'Enter') { |
There was a problem hiding this comment.
I don't quite understand this. If checkErrorsAndSubmit is triggered by the the @keydown.enter="checkErrorsAndSubmit" event handler, why do you need to check in the event key is 'Enter'? https://vuejs.org/guide/essentials/event-handling.html#key-modifiers
There was a problem hiding this comment.
Sorry, you're right. It was a mistake. I will fix it.
There was a problem hiding this comment.
@jredrejo I have corrected it.
|
Hi @a6ar55, thanks for following-up. We will re-review. |
jredrejo
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-displays form validation error when enter is clicked.(Password do not match)
Screen.Recording.2023-11-04.at.2.04.16.PM.mov
References
This fixes issue #11465
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarnandpip)