Skip to content

Commit

Permalink
Remove code coverage reporting, due to difficulties supporting Python…
Browse files Browse the repository at this point in the history
… 3.6 and 3.11
  • Loading branch information
rtibbles committed Jul 17, 2024
1 parent 8111f14 commit 5a7f055
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 201 deletions.
1 change: 0 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@

## Reviewer checklist

- Automated test coverage is satisfactory
- PR is fully functional
- PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)
- External dependency files were updated if necessary (`yarn` and `pip`)
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/c_extensions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ jobs:
make staticdeps-cext
pip install .
# Start and stop kolibri
coverage run -p kolibri start --port=8081
coverage run -p kolibri stop
kolibri start --port=8081
kolibri stop
# Run just tests in test/
py.test --cov=kolibri --cov-report= --cov-append --color=no test/
py.test --color=no test/
no_c_ext:
name: No C Extensions
needs: pre_job
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
make staticdeps
pip install .
# Start and stop kolibri
coverage run -p kolibri start --port=8081
coverage run -p kolibri stop
kolibri start --port=8081
kolibri stop
# Run just tests in test/
py.test --cov=kolibri --cov-report= --cov-append --color=no test/
py.test --color=no test/
1 change: 0 additions & 1 deletion docs/stack.rst
Original file line number Diff line number Diff line change
Expand Up @@ -71,5 +71,4 @@ We use a number of mechanisms to help encourage code quality and consistency. Mo
- `pytest <http://pytest.org/latest/>`__ runs our Python unit tests. We also leverage the `Django test framework <https://docs.djangoproject.com/en/1.11/topics/testing/>`__.
- In addition to building client assets, `webpack <https://webpack.github.io/>`__ runs linters on client-side code: `ESLint <http://eslint.org/>`__ for ES6 JavaScript, `Stylelint <https://stylelint.io/>`__ for SCSS, and `HTMLHint <http://htmlhint.com/>`__ for HTML and Vue.js components.
- Client-side code is tested using `Jest <https://facebook.github.io/jest/>`__
- `codecov <https://codecov.io/>`__ reports on the test coverage
- We have `Sentry <https://docs.sentry.io/>`__ clients integrated (off by default) for automated error reporting
2 changes: 0 additions & 2 deletions requirements/test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@
beautifulsoup4==4.8.2
factory-boy==2.7.0
fake-factory==0.5.7
coverage==6.2
mock==2.0.0
mixer==6.0.1
pytest-cov==3.0.0
pytest==6.2.5
pytest-django==4.5.2
pytest-env==0.6.2
Expand Down
187 changes: 0 additions & 187 deletions test/coverage_blame.py

This file was deleted.

8 changes: 4 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ deps =
commands =
sh -c 'kolibri manage makemigrations --check'
# Run the actual tests
python -O -m pytest {posargs:kolibri --cov=kolibri --cov-report= --cov-append --color=no}
python -O -m pytest --cov=kolibri --cov-report= --cov-append --color=no -p no:django test
python -O -m pytest {posargs:kolibri --color=no}
python -O -m pytest --color=no -p no:django test
# Fail if the log is longer than 200 lines (something erroring or very noisy got added)
sh -c "if [ `cat {env:KOLIBRI_HOME}/logs/kolibri.txt | wc -l` -gt 200 ] ; then echo 'Log too long' && echo '' && tail -n 20 {env:KOLIBRI_HOME}/logs/kolibri.txt && exit 1 ; fi"

Expand All @@ -54,5 +54,5 @@ deps =
-r{toxinidir}/requirements/cext.txt
-r{toxinidir}/requirements/postgres.txt
commands =
python -O -m pytest {posargs:kolibri --cov=kolibri --cov-report= --cov-append --color=no}
python -O -m pytest --cov=kolibri --cov-report= --cov-append --color=no -p no:django test
python -O -m pytest {posargs:kolibri --color=no}
python -O -m pytest --color=no -p no:django test

0 comments on commit 5a7f055

Please sign in to comment.