Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump KDS version to 5.0.0-rc6 #787

Merged
merged 4 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,17 @@ Changelog is rather internal in nature. See release notes for the public overvie

<!-- [DO NOT REMOVE-USED BY GH ACTION] PASTE CHANGELOG -->

- [#784]
- **Description:** Adds `labelDir` prop to control rtl direction of label.
- **Products impact:** new API.
- **Addresses:** https://github.com/learningequality/studio/issues/4728.
- **Components:** KCheckbox, KRadioButton.
- **Breaking:** no
- **Impacts a11y:** no.
- **Guidance:** -.

[#784]: https://github.com/learningequality/kolibri-design-system/pull/784

- [#767]
- **Description:** Bump KDS version to 4.5.0.
- **Products impact:** -.
Expand Down
10 changes: 9 additions & 1 deletion lib/KCheckbox.vue
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
</div>

<label
dir="auto"
:dir="labelDir"
class="k-checkbox-label"
:for="id"
:class="{ 'visuallyhidden': !showLabel }"
Expand Down Expand Up @@ -84,6 +84,14 @@
type: String,
default: null,
},
/**
* RTL dir of the text label
* Options: 'auto', 'ltr', 'rtl', null.
*/
labelDir: {
type: String,
default: 'auto',
},
/**
* Whether or not to show the label
*/
Expand Down
10 changes: 9 additions & 1 deletion lib/KRadioButton.vue
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
</div>

<label
dir="auto"
:dir="labelDir"
class="k-radio-button-label"
:for="id"
:class="{ 'visuallyhidden': !showLabel }"
Expand Down Expand Up @@ -99,6 +99,14 @@
type: Boolean,
default: true,
},
/**
* RTL dir of the text label
* Options: 'auto', 'ltr', 'rtl', null.
*/
labelDir: {
type: String,
default: 'auto',
},
/**
* Component `data` with which to associate this radio button and its siblings
*/
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "kolibri-design-system",
"version": "5.0.0-rc5",
"version": "5.0.0-rc6",
"private": false,
"description": "The Kolibri Design System defines common design patterns and code for use in Kolibri applications",
"repository": {
Expand Down