Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCheckbox: Remove local state management, rely on given props #744

Merged

Commits on Aug 29, 2024

  1. KCheckbox: Remove local state management, rely on given props

        KCheckbox had local data which are initialized to the given props for
        `indeterminate` and `checked` and then updated in a watcher. This
        resulted in that clicking a checkbox would always toggle it's
        `isCurrentlyChecked` value and setting `isCurrentlyIndeterminate` to
        false.
    
        The changes here instead have KCheckbox simply use the given prop values
        and does nothing to manage any internal state around whether it shows
        `indeterminate` and/or `checked`.
    
        This results in users of KCheckbox needing to be mindful of how they
        manage the values they pass into KCheckbox's props as the component will
        now reflect their values at all time
    nucleogenesis committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    325a8ca View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    49aaebe View commit details
    Browse the repository at this point in the history