Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.js upgrade to v18 along with dependency upgrades and linting fixes #645
base: release-v4
Are you sure you want to change the base?
Node.js upgrade to v18 along with dependency upgrades and linting fixes #645
Changes from 8 commits
14190d6
4300f04
3020dfd
0d82020
3ece1f1
8a61249
81d1c5b
1e3f048
96495ce
b80a56c
0beb457
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when I run
yarn lint
,yarn dev
I get this error because I dont have pnpm installed:Does the new version of kolibri-tools require pnpm to be installed? If so I think we need to add this to our prerequisites.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be no requirement on
pnpm
-- nothing in regards to that has changed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you previously run a
corepack
command on your system?I don't think this will resolve the issue, but you could try adding
export SKIP_YARN_COREPACK_CHECK=1
to your terminal env.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, no, that didn't solve it. It's weird because I tried to run it on my Windows machine, where I also don't have Pnpm, and it worked there 🤔
In my Ubuntu machine I finally installed pnpm using
volta install pnpm
and thenyarn lint
worked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we used the same approach from another component (instead of using
uuid
library), could there be any conflicts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only if the ID prefix wasn't already unique