fix broken internal links #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you, @indirectlylit :)! |
MisRob
added
category: supporting code
MisRob
reviewed
Oct 10, 2023
| @@ -26,6 +26,9 @@ | |||
| href: { | |||
| type: String, | |||
| required: true, | |||
| validator(value) { | |||
| return value.startsWith('/') || value.startsWith('#'); | |||
MisRob
approved these changes
Oct 10, 2023
|
my pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue addressed
Follow-up from #423
Many instances of
DocsInternalLinkwere broken on the Netlify deployed site. This wasn't obvious because the links worked fine from the dev server. The difference is because Netlify adds a trailing slash to all URLs:https://docs.netlify.com/routing/redirects/redirect-options/#trailing-slash
Found instances with regex:
<DocsInternalLink(.|\n)*?href="[^/]Before/after screenshots
Steps to test
Check links on netlify vs locally
Reviewer guidance