-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Student Onsite Webapp #2507
Student Onsite Webapp #2507
Conversation
@milescalabresi , @benjaminjkraft (really @ everyone); This is very exciting! Will and I talked about perhaps beta testing it at the upcoming Berkeley Splash (March 4th)... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few minor interface tweaks for the student schedule. Not super-critical; probably won't make it on live-branch (local berkeley_prod) before UC Berkeley Splash
<!--otherwise, grey out icon--> | ||
<i class="material-icons md-4 greyed">{% if cls %}create{% else %}add{% endif %}</i> | ||
{% if cls %} | ||
<i class="material-icons md-4 greyed">clear</i> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the greyed out icon was pretty non-obvious in terms of its usage; I tried clicking it for a while before I realized/remembered I had to be checked in. :P Maybe just no icon here? I don't know what the greyed out icon is supposed to communicate to the student...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, wouldn't no icon look weird, because there'd be a big gap (as it is, it's all nice and symmetrical)? In chatting, you suggested adding a popup, which I think could be a nice alternative!
@bhorowitz I've added a note and popup as discussed. Let me know what you think. |
Students can now click on the location for a class on their schedule and get google maps walking directions to the location of that class. This requires that a "Lat/Long" resource be associated with the classroom, and the |
This comment has been minimized.
This comment has been minimized.
OK, that should do it, this is good to be reviewed for merging! @kkbrum @hwatheod @bhorowitz |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't triple check the map stuff because I don't feel like setting up the google api key and locations for my classes, but if you'd like me to, let me know and I can.
I tried to look over the newer changes and it looks pretty good to me (few comments), but definitely let me know if there's anything in particular you'd like some thorough testing on.
This comment has been minimized.
This comment has been minimized.
OK, that should address all of your concerns @kkbrum. I haven't made any functionality changes to the map since it's been live on Stanford, Berkeley, and Yale, so I think it should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Superb!
This pull request introduces 2 alerts when merging abae9e8 into 7e5da59 - view on LGTM.com new alerts:
|
* First documentation for sr12 * Add link from main readme * fix link * More docs * Update search bar docs * docs for #2852 * More docs * doc for #2850 * Docs for #2868 * More docs * Add student acknowledgement module and student phone number changes * Docs for #2844, #2865, #2861, #2871, #2872 * Docs for #2463 * Docs for #2900, #2816, and #2862 * Document nametag barcodes * Docs for #2912, #2913, #2914, and #2915 * Docs for #2903 * More docs for #2903 * Fix styling * add explainer video for attendance module * Docs for #2916 * Docs for #2925, #2866, and #2901 * Docs for #2932 and #2933 * Docs for #2507 * Docs for #1772 and #2923 * Docs for #2929 * Docs for #2942 and #2943 * Docs for #2945 and #2935 * Fix sublist * Docs for #2957 and #2960 * Docs for #2958 and #2962 * Docs for #2974, #2975, #2976, and #2977 * Docs for #2979 and #2982 * Docs for #2970 and #2973 * Docs for #2963 and #2967 * Docs for #2941, #2936, and #2999 * Add docs for #2986 * More docs for #2986 * Docs for #2966, #2988, and #3001 * add module selection changes * Docs for #3015, #3017, and other misc changes * Add known issues * Student and teacher webapp docs * Add note about setup * Update docs for survey module and other misc modules * Update release date * Docs for new onsite modules * Docs for #3012, #2998, and certificate * Update known issues * Docs for #3000 * Update docs about privacy policy * Fix typo * Remove issue * Remove issue * Remove video, add youtube link * Merge student acknowledgment docs * Minor edits * Update module docs based on PR #1528 * Docs for #1528 * Formatting fix Co-authored-by: Katherine <[email protected]> Co-authored-by: Miles Calabresi <[email protected]>
* Webapp handler and dummy templates * Migration for new module. * css file, prep for dynamic schedule * Dynamic schedule. * Catalog and survey templates. Fixed aux_calls * Catalog updates * Catalog shows class info. Can be filtered by timeslot. * Checks for attendance status. Adds buttons to enroll in classes. * Button almost works * Catalog is now cached. Enrollment buttons now work. * Ability to remove classes from schedule. * Filters classes by student grade when looking at specific timeslot. * Style changes * Style changes, add buttons now disabled if there are class conflicts * More style changes * Maps update. * Style changes * prepare fix * lint fix * isStep and map fixes * Not checked in note on schedule * Added popup when buttons are clicked when not checked in * Pulls classroom lat/long data from an associated resource (if one exists) * Switch to /default_styles * Fixes directions origin precision, map overlap with navbar * Add backup directions map if user does not give tracking permission * migrations are bad...mmkay * meh, they aren't that bad * fixes for travis * fixes for travis 2 * Pulled out shared code, added scroll button on catalog * Handle invalid classroom ids * Switch to Javascript API for directions, refresh directions every 30 seconds * Fix caching and check for cancelled sections * Webapp catalog bug fixes * Map fixes * Include fixes from #2597 * Prettier category buttons * Prettier classroom links * Let students enroll in classes based on checked in numbers * Include new tags in tag lists * test fix * Sort fillslot like catalog * factor out code * use factored out category sorting code * fix implementation * Fix logic for reg based on checked-in records * Remove walk-in buttons, fix category buttons, fix gap * Change seq * Fix migration * Remove unnecessary imports * Make directions button more obvious * Fix map height * Raise error if problem encountered while clearing timeslot * Mark webapp enrollments with webapp student registration * Update tagdict * Add built-in survey, fix styling * Lint fix * Expand category buttons for longer categories * Fix #2937 * Fix textareas to 100% width * Prevent horizontal resizing
This provides a mobile-friendly interface for students to perform common functions that might be desired at a Splash program:
The hope is to deploy for at-scale tests for Berkeley Splash on March 4th.
All comments are welcome!
Screenshots:
Schedule:
Map:
Catalog:
Filtered catalog:
Survey:
Fixes #1545 and fixes #1208