Passed all tests #23
Open
Passed all tests #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+2
to
+6
| const currentUser = 'Grace Hopper'; | ||
| const welcomeMessage = `Welcome to Flatbook, ${currentUser}!`; | ||
| const excitedWelcomeMessage = welcomeMessage.toUpperCase(); | ||
|
|
||
| const shortGreeting = `Welcome, ${currentUser.slice(0,1)}!`; |
There was a problem hiding this comment.
Any reason for the inconsistent line spacing?
Author
There was a problem hiding this comment.
Not exactly. I just wanted some separation I guess. What are the usual conventions for line spacing in code?
There was a problem hiding this comment.
There usually aren't any strict conventions around spacing in this sense--mostly personal preference. I would say lean toward readability and consistency.
I was mostly just curious if you added the space for a certain reason or not. Seems like you had one and usually that's all that matters, if you see what I mean.
|
@yuriiivan Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.