fix: add cmake COPY_CADICAL option to allow turning off install copy #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
juhp
changed the title
|
Okay now reworked to be a cmake option ( |
|
Okay cadical seems back in CI |
|
(Well I can't help feeling that strictly speaking |
Kha
requested changes
Nov 5, 2024
| @@ -75,6 +75,7 @@ option(USE_GMP "USE_GMP" ON) | |||
| # development-specific options | |||
| option(CHECK_OLEAN_VERSION "Only load .olean files compiled with the current version of Lean" OFF) | |||
| option(USE_LAKE "Use Lake instead of lean.mk for building core libs from language server" OFF) | |||
| option(COPY_CADICAL "Install a copy of cadical" ON) | |||
There was a problem hiding this comment.
This is not a dev-specifc option, please put it below INSTALL_LICENSE. INSTALL_CADICAL would likely be a more appropriate name then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cmake knob to turn off installing a copy of
cadical.This can be useful for custom builds/installs where cadical is already available in the system.
Closes: #5603