Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't issue atomic id completions when there is a dangling dot #5837

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

fix: don't issue atomic id completions when there is a dangling dot #5837

wants to merge 6 commits into from

Conversation

mhuisi
Copy link
Contributor

@mhuisi mhuisi commented Oct 25, 2024

Fixes an old completion bug where x. would issue nonsensical completions when x. could not be elaborated as a dot completion.

Based on #5835.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 25, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f0c190239a5e2d7f99413da0c54a575a0d0353b6 --onto 193b6f2bec332ac0bce33e10856a96163d4be456. (2024-10-25 13:10:37)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhuisi @leanprover-community-bot