-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simp local confluence testing #5717
base: master
Are you sure you want to change the base?
Conversation
tests/simplc/Simplc.lean
Outdated
logInfo m!"Checking {thms.size} simp lemmas for critical pairs" | ||
let filtered_sthms := thms.foldl Lean.Meta.addSimpTheoremEntry (init := {}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logInfo m!"Checking {thms.size} simp lemmas for critical pairs" | |
let filtered_sthms := thms.foldl Lean.Meta.addSimpTheoremEntry (init := {}) | |
logInfo m!"Checking {thms.size} simp lemmas for critical pairs" | |
let filtered_sthms := thms.foldl Lean.Meta.addSimpTheoremEntry (init := {}) |
Should this logInfo
become a trace option?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I'll leave this to Kim who has the most experience actually using the tool.
In general I think there is a need for information from tactics/command that you can easily get, but doesn't show up in All Messages nor the build log. Maybe a custom hover. Until then a trace works.
Mathlib CI status (docs):
|
Co-authored-by: Tobias Grosser <[email protected]>
Co-authored-by: Tobias Grosser <[email protected]>
This adds @nomeata's simp local confluence testing tool in
tests/simplc
, and sets up whitelists to run this on the core Lean library.The README contains instructions for running this is in downstream repositories.
I have not yet hooked this up to CI.