Skip to content

refactor: some Meta.Match.Match refactorings #11011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 29, 2025
Merged

refactor: some Meta.Match.Match refactorings #11011

merged 4 commits into from
Oct 29, 2025

Conversation

@nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 29, 2025 •
edited
Loading

This PR extracts some refactorings from #10763, including dropping dead
code and not failing in inaccessibleAsCtor, which leadas to (slightly)
better error messages, and also on the grounds that the failing
alternative may actually be unreachable.

@nomeata
refactor: some Meta.Match.Match refactorings
88b0fbe 
This PR extracts some refactorings from #10763, including dropping dead
code and not failing in `inaccessibleAsCtor`, which leadas to (slightly)
better error messages, and also on the grounds that the failing
alternative may actually be unreachable.
@nomeata nomeata added the changelog-language Language features and metaprograms label Oct 29, 2025
@nomeata nomeata changed the title joachim/processInaccessibleAsCtor refactor: some Meta.Match.Match refactorings Oct 29, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 29, 2025
@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Oct 29, 2025

Reference manual CI status:

  • ❗ Reference manual CI can not be attempted yet, as the nightly-testing-2025-10-29 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-manual, reference manual CI should run now. You can force reference manual CI using the force-manual-ci label. (2025-10-29 13:44:24)

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11011
000b669
@nomeata nomeata closed this Oct 29, 2025
@nomeata nomeata reopened this Oct 29, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for leanprover/lean4#11011
2f38c5f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4-nightly-testing that referenced this pull request Oct 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#11011
9396339
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 29, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 29, 2025

Mathlib CI status (docs):

@nomeata nomeata marked this pull request as ready for review October 29, 2025 23:24
@nomeata nomeata added this pull request to the merge queue Oct 29, 2025
Merged via the queue into master with commit e2f5938 Oct 29, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nomeata @leanprover-bot @leanprover-community-bot