● fix: force bibPrepass rebuild when references.bib is missing#356
Open
arajasek wants to merge 1 commit intoleanprover:mainfrom
Open
● fix: force bibPrepass rebuild when references.bib is missing#356arajasek wants to merge 1 commit intoleanprover:mainfrom
arajasek wants to merge 1 commit intoleanprover:mainfrom
Conversation
bibPrepass writes doc/references.bib as a side effect, but only doc-data/references.json is tracked by buildFileUnlessUpToDate'. When the tracked output is restored from cache without the side effect, Lake skips bibPrepass and the docs build fails
Collaborator
|
This seems like quite a hack to me, if anything we should improve the tracking of dependencies and not trick lake into doing our bidding by deleting artifacts. |
Author
|
Yeah, this one is optional -- the real fix was leanprover-community/docgen-action#22. I just wanted to make it more robust, because it seems like we keep hitting edge-cases that prevent this from working. Feel free to close this as a wontmerge, though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bibPrepasswritesdoc/references.bibas a side effect, but onlydoc-data/references.jsonis tracked bybuildFileUnlessUpToDate'. When the tracked output is restored from cache without the side effect, Lake skipsbibPrepassand the docs build fails