Add writing numpy tensors back to disk #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested by round-tripping in the python repl. Unit tests are forthcoming.
govereau
approved these changes
Nov 14, 2024
| @@ -514,5 +526,57 @@ def parseFile (path: System.FilePath) : IO (Except String NumpyRepr) := do | |||
|
|
|||
| end Parse | |||
|
|
|||
| section Save | |||
|
|
|||
| private def pushList (a : ByteArray) (xs : List UInt8) : ByteArray := xs.foldl (fun a b => a.push b) a | |||
There was a problem hiding this comment.
Is it more efficient to use ByteArray.append, List.toArray ?
There was a problem hiding this comment.
Probably. Will swap.
|
|
||
| private def pushChars (a : ByteArray) (xs : List Char) : ByteArray := xs.foldl (fun a b => a.push (b.toUInt8)) a | ||
|
|
||
| private def pushString (a : ByteArray) (xs : String) : ByteArray := pushChars a xs.toList |
There was a problem hiding this comment.
Similar comment: String.toUTF8?
There was a problem hiding this comment.
ah didn't know about that one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed because while we will generally mutate the data in place, we will need to write new headers, e.g. for the potentially changed shape and row/column ordering. Moreover, for tensors we create from scratch, we will not in general have bits representing the header.
Tested by round-tripping in the python repl.
Unit tests are forthcoming.