feat: Switch to using bv_decide to decide memory goals instead of bv_omega #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simproc simplifies expressions by attempting to constant fold using `omega` to make sure we never see modulos, and moves all arithmetic constants to the left. The goal is for this to be upstreamed sooner rather than later.
Co-authored-by: Alex Keizer <[email protected]>
… directly invoke `omega`
…c on nats I'm considering switching the `n` in `mem_legal' a n` to a `BitVec 64`, but it maybe possible to write preprocessing to write the proof state purely in terms of bitvectors; Let's first get enough to try to push `memcpy` proof through.
This one is particularly interesting, since we see where bitvec theory limits us: we can't reason about the fact that the length = 80!.
…h stuff is messed up
…' that takes bitvec as argument
…m_bytes' and write_mem_bytes', this is a total disaster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In facing scaling issues with
omega, we've taken a step back, and are considering using a SAT solver viabv_omegato discharge our memory goals. This branch will try an experiment, where we will replace the core definitions ofmem_legal', mem_subset', mem_separate'to be SAT solver friendly, and will rewrite the surrounding tactics to use these theorems instead.Testing:
What tests have been run? Did
make allsucceed for your changes? Wasconformance testing successful on an Aarch64 machine?
License:
By submitting this pull request, I confirm that my contribution is
made under the terms of the Apache 2.0 license.