Skip to content

Conversation

@BoltonBailey
Copy link
Collaborator

@BoltonBailey BoltonBailey commented Nov 19, 2025

This PR adds a lemma for splitOnP, allowing expressions where a splitOnP on a concatenation to be better simplified. Also golfs a relevant consequence with the new lemma.

Related to google-deepmind/formal-conjectures#1120


Open in Gitpod

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

PR summary b9fc957e0c

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ splitOnP_append_cons

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-data Data (lists, quotients, numbers, etc) label Nov 19, 2025
@BoltonBailey BoltonBailey changed the title feat: add two simp lemmas related to splitOnP feat: add two lemmas related to splitOnP Nov 19, 2025
@BoltonBailey BoltonBailey changed the title feat: add two lemmas related to splitOnP feat: add splitOnP_append_cons Nov 19, 2025
@BoltonBailey BoltonBailey marked this pull request as draft November 19, 2025 20:49
@BoltonBailey BoltonBailey marked this pull request as ready for review November 19, 2025 21:05
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 20, 2025
mathlib-bors bot pushed a commit that referenced this pull request Nov 20, 2025
This PR adds a lemma for `splitOnP`, allowing expressions where a `splitOnP` on a concatenation to be better simplified. Also golfs a relevant consequence with the new lemma.

Related to google-deepmind/formal-conjectures#1120
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 20, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add splitOnP_append_cons [Merged by Bors] - feat: add splitOnP_append_cons Nov 20, 2025
@mathlib-bors mathlib-bors bot closed this Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR has been sent to bors. t-data Data (lists, quotients, numbers, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants