-
Notifications
You must be signed in to change notification settings - Fork 892
[Merged by Bors] - feat: add splitOnP_append_cons
#31825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
BoltonBailey
wants to merge
6
commits into
leanprover-community:master
from
BoltonBailey:splitOnP-simp
Closed
[Merged by Bors] - feat: add splitOnP_append_cons
#31825
BoltonBailey
wants to merge
6
commits into
leanprover-community:master
from
BoltonBailey:splitOnP-simp
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary b9fc957e0cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diff
You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
splitOnPsplitOnP
splitOnPsplitOnP_append_cons
jcommelin
reviewed
Nov 20, 2025
Member
jcommelin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 20, 2025
This PR adds a lemma for `splitOnP`, allowing expressions where a `splitOnP` on a concatenation to be better simplified. Also golfs a relevant consequence with the new lemma. Related to google-deepmind/formal-conjectures#1120
Contributor
|
Pull request successfully merged into master. Build succeeded: |
splitOnP_append_conssplitOnP_append_cons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lemma for
splitOnP, allowing expressions where asplitOnPon a concatenation to be better simplified. Also golfs a relevant consequence with the new lemma.Related to google-deepmind/formal-conjectures#1120