[Merged by Bors] - chore: add @[expose] public section in Mathlib.RingTheory.AdicCompletion.RingHom
#31822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorimur
added
easy
PR summary b9fc957e0cImport changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
github-actions
bot
removed
the
awaiting-CI
grunweg
reviewed
Nov 19, 2025
Collaborator
grunweg
left a comment
grunweg
left a comment
There was a problem hiding this comment.
Good catch, thanks!
bors merge
leanprover-community-mathlib4-bot
added
the
ready-to-merge
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
@[expose] public section in Mathlib.RingTheory.AdicCompletion.RingHom@[expose] public section in Mathlib.RingTheory.AdicCompletion.RingHom
1 task
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
This linter lints against nonempty modules that have only private declarations, and suggests adding `@[expose] public section` to the top. This linter found 1 violation in Mathlib, which was fixed in #31822. Co-authored-by: thorimur <[email protected]> Co-authored-by: Jovan Gerbscheid <[email protected]> Co-authored-by: Bryan Gin-ge Chen <[email protected]>
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
This linter lints against nonempty modules that have only private declarations, and suggests adding `@[expose] public section` to the top. This linter found 1 violation in Mathlib, which was fixed in #31822. Co-authored-by: thorimur <[email protected]> Co-authored-by: Jovan Gerbscheid <[email protected]> Co-authored-by: Bryan Gin-ge Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed in #31149. Found by the linter in #31820.