Skip to content

Conversation

@kckennylau
Copy link
Collaborator

@github-actions
Copy link

github-actions bot commented Nov 19, 2025

PR summary a73de4ba4b

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@kckennylau kckennylau added t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory labels Nov 19, 2025
Comment on lines 231 to 232
unfold modByMonic divByMonic divModByMonicAux
dsimp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that github has mangled the diff here anyway (i.e. isn't just saying "you added two lines" it's saying "you deleted a proof and replaced it with what looks to me like a different proof but actually it's the same proof indented two spaces more" you may as well golf this if you can -- can all the unfolds be put into the dsimp and rw?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've golfed it a bit, but the unfold and rw still can't be combined to one line (dsimp doesn't work either)

@kbuzzard
Copy link
Member

Nice -- this is clearly better.

Copy link
Collaborator

@artie2000 artie2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like you missed any lemmas!

refine ih.trans ?_
rw [divByMonic, dif_pos hq, dif_pos hq, dif_pos h, mul_add, sub_add_eq_sub_sub]
else by
unfold modByMonic divByMonic divModByMonicAux
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move divByMonic_eq_of_not_monic and modByMonic_eq_of_not_monic earlier so the non-monic branches you add can be closed in one line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is already one line (here), and it already uses divByMonic_eq_of_not_monic and modByMonic_eq_of_not_monic, and what you linked to isn't the non-monic branch, but rather the branch that says "division is done here and you can go home and have dinner"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad!

@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 20, 2025
@jcommelin jcommelin self-assigned this Nov 20, 2025
@kckennylau kckennylau removed the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 20, 2025
@artie2000
Copy link
Collaborator

LGTM

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Nov 21, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 21, 2025

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 21, 2025

Build failed (retrying...):

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 21, 2025

Build failed (retrying...):

@bryangingechen
Copy link
Contributor

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 21, 2025

✌️ kckennylau can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 21, 2025

Canceled.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). and removed ready-to-merge This PR has been sent to bors. delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). labels Nov 21, 2025
@jcommelin jcommelin added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-author A reviewer has asked the author a question or requested changes. t-algebra Algebra (groups, rings, fields, etc) t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants