Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Topology): Introduce HomeomorphClass #18689

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

Thmoas-Guan
Copy link
Collaborator

Introduce HomeomorphClass


Open in Gitpod

@github-actions github-actions bot added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Nov 6, 2024
Copy link

github-actions bot commented Nov 6, 2024

PR summary 65762b3153

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HomeomorphClass
+ coe_coe
+ instance : HomeomorphClass (α ≃ₜ β) α β
+ instance [HomeomorphClass F α β] : CoeTC F (α ≃ₜ β)
+ toHomeomorph
+ toHomeomorph_injective

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition! Can you please also add the analogue of this lemma, and address my comments below?

@[simp]
theorem RingHom.coe_coe {α : Type u_2} {β : Type u_3} :
∀ {x : NonAssocSemiring α} {x_1 : NonAssocSemiring β} {F : Type u_5} [inst : FunLike F α β]
  [inst_1 : RingHomClass F α β] (f : F), ⇑↑f = ⇑f

Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Comment on lines +1070 to +1071
instance [HomeomorphClass F α β] : CoeTC F (α ≃ₜ β) :=
⟨HomeomorphClass.toHomeomorph⟩
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please ask on Zulip what is the correct class to use here. CoeTC is not preferred (although it's littered throughout Mathlib). We need to come to a consensus on Zulip about which Coe class is best for coercions from morphism classes to morphisms.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked in a thread of PR review, needed anywhere else?

Comment on lines +1073 to +1074
theorem toHomeomorph_injective [HomeomorphClass F α β] : Function.Injective ((↑) : F → α ≃ₜ β) :=
fun _ _ e ↦ DFunLike.ext _ _ fun a ↦ congr_arg (fun e : α ≃ₜ β ↦ e.toFun a) e
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have this for other morphism classes. I suspect it's not necessary as we can just apply the coercion to functions and then use DFunLike.coe_injective (probably after simp)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this lemma from MulEquivClass, I didn't think carefully whether it is useful.

@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes label Nov 6, 2024
@Thmoas-Guan Thmoas-Guan removed the awaiting-author A reviewer has asked the author a question or requested changes label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants