-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Topology): Introduce HomeomorphClass #18689
base: master
Are you sure you want to change the base?
Conversation
PR summary 65762b3153Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition! Can you please also add the analogue of this lemma, and address my comments below?
@[simp]
theorem RingHom.coe_coe {α : Type u_2} {β : Type u_3} :
∀ {x : NonAssocSemiring α} {x_1 : NonAssocSemiring β} {F : Type u_5} [inst : FunLike F α β]
[inst_1 : RingHomClass F α β] (f : F), ⇑↑f = ⇑f
instance [HomeomorphClass F α β] : CoeTC F (α ≃ₜ β) := | ||
⟨HomeomorphClass.toHomeomorph⟩ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ask on Zulip what is the correct class to use here. CoeTC
is not preferred (although it's littered throughout Mathlib). We need to come to a consensus on Zulip about which Coe
class is best for coercions from morphism classes to morphisms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asked in a thread of PR review, needed anywhere else?
theorem toHomeomorph_injective [HomeomorphClass F α β] : Function.Injective ((↑) : F → α ≃ₜ β) := | ||
fun _ _ e ↦ DFunLike.ext _ _ fun a ↦ congr_arg (fun e : α ≃ₜ β ↦ e.toFun a) e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we have this for other morphism classes. I suspect it's not necessary as we can just apply the coercion to functions and then use DFunLike.coe_injective
(probably after simp
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this lemma from MulEquivClass
, I didn't think carefully whether it is useful.
and fix docstring
Introduce HomeomorphClass