refactor to remove stateful logic fromnested handler - #25
Merged
Conversation
tswast
commented
Dec 12, 2025
|
|
||
| print("\n📋 NEW way (full SQL power):") | ||
| print(" 1. Prepare: Extract nested fields") | ||
| print(" 2. Join: Use Ibis directly") |
Collaborator
Author
There was a problem hiding this comment.
@andyorange Do you think we should make a public data property for this? Or perhaps a to_ibis() method that returns ._data to give ourselves a bit more flexibility?
Collaborator
There was a problem hiding this comment.
Souds like a good idea, let us check Monday so you can explain your ideas in more details!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.