Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotnet 8 support #298

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

Goltom
Copy link
Contributor

@Goltom Goltom commented Jan 16, 2024

  • Add support for .net8
  • IPNetwork renamed to IPNetwork2
  • Update nuget package Microsoft.NET.Test.Sdk
  • Unittest fix

Tommi Golinelli added 2 commits January 16, 2024 15:25
- add support for .net8
- update nuget package Microsoft.NET.Test.Sdk
@mergify mergify bot mentioned this pull request Jan 16, 2024
@coveralls
Copy link

coveralls commented Jan 16, 2024

Pull Request Test Coverage Report for Build 624

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.615%

Totals Coverage Status
Change from base Build 618: 0.0%
Covered Lines: 1599
Relevant Lines: 1690

💛 - Coveralls

@Goltom Goltom mentioned this pull request Jan 16, 2024
@lduchosal
Copy link
Owner

lduchosal commented Jan 17, 2024

Well, everyone tracking ipnetwork nuget will get its build broken:

  • This should be upgrade a new major versionv 3.0.0
  • Documentation (README.md) should be modifed accordingly
  • Automatic Build should be upgraded to use net8
  • Test units and code coverage must pass

@lduchosal lduchosal merged commit 85a427c into lduchosal:master Jan 17, 2024
6 of 8 checks passed
@lduchosal
Copy link
Owner

Thanks for you help

@Maxwell175
Copy link

Maxwell175 commented Jan 17, 2024

@lduchosal The better solution should have been to move everything out of the System namespace entirely. Because it is intended to only be used by Microsoft. Otherwise we are just waiting for Microsoft to add their own IPNetwork2 and then we have the same issue once again.

@lduchosal
Copy link
Owner

Sure, PR welcome ! @Maxwell175

@Goltom
Copy link
Contributor Author

Goltom commented Jan 18, 2024

Thanks for you help

You are welcome :)

@Goltom Goltom deleted the add-dotnet-8-support branch January 30, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants