Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non-tool catalyst handling #10392

Open
wants to merge 3 commits into
base: version/main
Choose a base branch
from
Open

Improve non-tool catalyst handling #10392

wants to merge 3 commits into from
+28 −20

Conversation

uecasm
Copy link
Contributor

@uecasm uecasm commented Nov 2, 2024

Closes #10037
Closes discord issue
Closes discord issue

Changes proposed in this pull request

  • When improving recipes, don't forget other important recipe details such as secondary outputs.
  • Now supports catalyst "tool" items (that appear as both input and output) that aren't damageable.
    • For example, this should recognise that it only needs 1 template when crafting multiple netherite tools/armour.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please (should port)

Side note: would anyone object strongly if I removed all uses of getNewInstance for recipes? (Separate to this PR.) It just seems to lead to these sorts of issues because it's too tolerant of missing parameters.

@Raycoms
Copy link
Contributor

Raycoms commented Nov 2, 2024

I wouldn't object to removal of getNewInstance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thodor12 Thodor12 Thodor12 approved these changes

@Raycoms Raycoms Raycoms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Netherite items no longer return template after cost reduction at blacksmith
3 participants
@uecasm @Raycoms @Thodor12