Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update previous food tags #10385

Open
wants to merge 1 commit into
base: version/1.21
Choose a base branch
from
Open

Update previous food tags #10385

wants to merge 1 commit into from

Conversation

Thodor12
Copy link
Contributor

Changes proposed in this pull request

  • Upon request of Ray after accidental merge. Updated the food tags to just datagen, not be included in the ItemFood
  • Undone food builder logic in ModItemsInitializer
  • Brought list code more in line with what Ray already made for the cook rework
  • Ran datagen, but no changes were made

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Thodor12
Undone some of the previous tag work, brought code more in line with …
e718edf 
…the cook rework (datagen was ran but no changes were necessary to json files)
Raycoms
Raycoms approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@Raycoms Raycoms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raycoms Raycoms Raycoms approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Thodor12 @Raycoms