Support Brick 2.0, newer servant-client etc. #4
+150
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses microlens-platform's mtl support to simplify a lot of code, there's probably a lot more that can be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent this afternoon getting this to compile with newer GHC/Brick/servant-client. I made a few stylistic changes along the way so I could read it more easily, which I can change back if they're particularly offensive. These changes probably warrant a 0.x version bump, at least. I haven't paid much attention to compiling with older GHCs, but I don't think I've done much that would make it not work on anything older than the deps support.
I also have some problems with showing transactions for my main account (savings works fine though), but that's something for another time.
Open to any comments, I mostly just wanted to get this working for me but thought the effort shouldn't just benefit me.