Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: testing an even older commit #2504

Closed
wants to merge 1 commit into from
Closed

Conversation

certik
Copy link
Contributor

@certik certik commented Feb 7, 2024

No description provided.

@Shaikh-Ubaid
Copy link
Collaborator

I am slightly confused. How are we testing an older commit? I could not see any file changes in this PR.

@certik
Copy link
Contributor Author

certik commented Feb 7, 2024

I reset to an older version and do a simple commit on top.

@certik
Copy link
Contributor Author

certik commented Feb 7, 2024

So it passed here. I am rerunning the macOS job again. I'll run it at least 5 times and see if I can trigger the hang. If not, then this commit might work. Then we just need to bisect it.

@anutosh491
Copy link
Collaborator

Okay I see the CI passes here. What does this tell us though ? And how do we reset to this commit !

@certik
Copy link
Contributor Author

certik commented Feb 8, 2024

Restarted again, running for the 3rd time. We want to be 100% sure it works.

This PR is testing the commit a5e3d04.

Assuming this commit works, then we just have to bisect until we find the problem. I suspect it could be some segfault in the symbolic support?

@certik
Copy link
Contributor Author

certik commented Feb 8, 2024

It looks like it is hanging now... So event his old commit fails.

@certik certik mentioned this pull request Feb 8, 2024
@certik
Copy link
Contributor Author

certik commented Feb 8, 2024

We need to go deeper: #2516.

@certik certik closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants