Fix isspace edge case #2489
Merged
Fix isspace edge case #2489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anutosh491
reviewed
Feb 7, 2024
|
Added the test, and also noticed a bug in the C++ implementation, so fixed the same. |
Ohh what's this ? Have you tested it out ? |
|
It is the same edge case, just for constant empty strings as well. I will write a test for it as well. |
certik
approved these changes
Feb 11, 2024
There was a problem hiding this comment.
I think this is fine.
@anutosh491 can you please review & merge?
anutosh491
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An empty string should return
Falsewhen theisspacemethod is called.