[WIP] Comparing core and lcache

.gitignore

@@ -1,3 +1,4 @@
 composer.lock
 /drush/
 /vendor/
+.DS_Store

circle.yml

@@ -4,67 +4,41 @@ machine:
     # https://circleci.com/docs/environment#php
     version: 5.6.14
   environment:
-    # DB config. Using default CircleCI's database.
-    DB_NAME: "circle_test"
-    DB_USERNAME: "ubuntu"
-    DB_PASSWORD: ""
-    DOCROOT: "$HOME/drupalcore"
-    SERVER: server.local
-    WEB_USER: $(whoami)
-    WEB_GROUP: www-data
-  hosts:
-    server.local: 127.0.0.1
+    TERMINUS_ENV: ci-$CIRCLE_BUILD_NUM
+    TERMINUS_SITE: d8lcache
+    DRUPAL_ADMIN_USERNAME: pantheon
+    # A random password is set in the dependencies:pre stage as a text file.
+    # This line reads the same file repeatedly. If the openssl call were used
+    # in this step, it would result in a different password being used in each
+    # line of other steps. Each CircleCI command runs in a separate shell.
+    DRUPAL_ADMIN_PASSWORD: $(cat ~/DRUPAL_ADMIN_PASSWORD)
 
 dependencies:
   cache_directories:
     - ~/.composer/cache
   pre:
+    - echo $(openssl rand -hex 8) > ~/DRUPAL_ADMIN_PASSWORD
+    # Set the PHP timezone so that Behat script does not fail.
+    # Using > instead of >> will overwrite the file and disable xdebug.
+    # xdebug makes composer slower.
+    #############- echo "date.timezone = 'US/Central'"  >  /opt/circleci/php/7.0.7/etc/conf.d/xdebug.ini
+    - git config --global user.email "[email protected]"
+    - git config --global user.name "Circle CI"
+  override:
     - composer global require "hirak/prestissimo:^0.3"
+    - composer global require pantheon-systems/terminus "<0.13.0"
     - composer global require drush/drush:8.*
-    # @todo, composer is probably a bad/slow way to install core here.
-    # Use something like drush's 
-    - git clone --branch 8.1.x https://git.drupal.org/project/drupal.git $DOCROOT
-    - cd $DOCROOT && composer install
-    # Add apache config.
-    # Modify user to make sure that there will be no permission issues.
-    - sudo usermod -a -G $WEB_GROUP $WEB_USER
-    # Add apache config.
-    - |
-      echo "<VirtualHost *:80>
-          UseCanonicalName Off
-          DocumentRoot %DOCROOT%
-          ServerName %SERVER%
-        <Directory %DOCROOT%>
-          Options FollowSymLinks
-          AllowOverride All
-          RewriteEngine On
-          RewriteBase /
-          RewriteCond %{REQUEST_FILENAME} !-f
-          RewriteCond %{REQUEST_FILENAME} !-d
-          RewriteRule %DOCROOT%/(.*)$ index.php/?q=$1 [L,QSA]
-          Order allow,deny
-          Allow from all
-        </Directory>
-      </VirtualHost>" > apache-vhost.conf
-    - cp apache-vhost.conf /etc/apache2/sites-available/default
-    - sudo sed -e "s?%DOCROOT%?$DOCROOT?g" --in-place /etc/apache2/sites-available/default
-    - sudo sed -e "s?%SERVER%?$SERVER?g" --in-place /etc/apache2/sites-available/default
-    - sudo a2enmod rewrite
-    - sudo service apache2 restart
+    - composer install
+  post:
+    - terminus auth login --machine-token=$TERMINUS_TOKEN
 test:
   pre:
-    # Copy the settings.local into place
-    # Disable sendmail binary to suppress any mailouts.
-    - echo 'sendmail_path = /bin/true' >> ~/.phpenv/versions/$(phpenv version-name)/etc/conf.d/circle.ini
-    - drush --yes --root=$DOCROOT site-install --db-url=mysql://$DB_USERNAME:[email protected]/$DB_NAME
-    - curl $SERVER
-    - cd $DOCROOT && drush en simpletest  -y
-    - cd $DOCROOT && composer config repositories.d8lcache vcs [email protected]:lcache/drupal-8.git
-    - cd $DOCROOT && composer require "drupal/lcache:dev-master#$CIRCLE_SHA1"
-    - cd $DOCROOT && drush en lcache -y
-
-  override:
-    - ./vendor/bin/phpcs --report=full --extensions=php,module,inc,theme,info --standard=vendor/drupal/coder/coder_sniffer/Drupal/ --ignore=vendor .
-    - cd $DOCROOT && /home/ubuntu/.phpenv/shims/php  core/scripts/run-tests.sh  --url  $SERVER  --module lcache    --php  /home/ubuntu/.phpenv/shims/php --verbose  --color
-
-
+    #- ./vendor/bin/phpcs --report=full --extensions=php,module,inc,theme,info,install --standard=vendor/drupal/coder/coder_sniffer/Drupal . --ignore=vendor,modules,core,drush,patches,tests
+    # Make a new multidev env from a vanilla D8 site.
+    - cd tests/circle-scripts && ./create-fresh-d8-site.sh
+    - cd tests/circle-scripts && ./clone-repo.sh
+    - cd tests/circle-scripts && ./core-vs-lcache.sh
+  #
+  #   - cd tests/circle-scripts && ./enable-modules.sh
+  # override:
+  #   - cd tests/circle-scripts && ./run-tests.sh

composer.json

@@ -10,10 +10,18 @@
         }
     ],
     "require": {
-        "lcache/lcache": "v0.3.*"
+        "lcache/lcache": "0.3.*"
     },
     "require-dev": {
+        "phpunit/phpunit": "4.*",
+        "phpunit/dbunit": "*",
         "drupal/coder": "^8.2.0-beta1",
-        "squizlabs/php_codesniffer": "2.0.*@dev"
-    }
+        "squizlabs/php_codesniffer": "2.0.*@dev",
+        "drush-ops/behat-drush-endpoint": "*",
+        "drupal/drupal-extension": "dev-master",
+        "drupal/drupal-driver": "dev-master"
+    },
+    "autoload": {
+        "psr-4": { "Drupal\\LCache\\Behat\\": "tests/behat/bootstrap/" }
+  }
 }

src/Backend.php

@@ -72,7 +72,6 @@ public function get($cid, $allow_invalid = FALSE) {
     if (is_null($entry->expiration)) {
       $entry->expiration = CacheBackendInterface::CACHE_PERMANENT;
     }
-
     $response->expire = $entry->expiration;
     return $response;
   }
@@ -81,16 +80,19 @@ public function get($cid, $allow_invalid = FALSE) {
    * {@inheritdoc}
    */
   public function getMultiple(&$cids, $allow_invalid = FALSE) {
+
     if (empty($cids)) {
       return;
     }
+
     $cache = array();
     foreach ($cids as $cid) {
       $c = $this->get($cid);
       if (!empty($c)) {
         $cache[$cid] = $c;
       }
     }
+
     $cids = array_diff($cids, array_keys($cache));
     return $cache;
   }

src/BackendFactory.php

@@ -41,7 +41,7 @@ public function __construct(Connection $connection) {
       $l1 = new \LCache\APCuL1();
     }
     $l2 = new \LCache\DatabaseL2($this->getPdoHandle());
-    $this->integrated = new \LCache\Integrated($l1, $l2);
+    $this->integrated = new \LCache\Integrated($l1, $l2, 100);
     $this->integrated->synchronize();
   }
 

tests/behat/behat-pantheon.yml

@@ -0,0 +1,22 @@
+#
+# behat.yml file for testing with a Drupal site on Pantheon.
+#
+default:
+  suites:
+    default:
+      contexts:
+        - Drupal\DrupalExtension\Context\DrupalContext
+        - Drupal\DrupalExtension\Context\DrushContext
+        - Drupal\DrupalExtension\Context\MinkContext
+        - Drupal\LCache\Behat\PerformanceHelpers
+  extensions:
+    Behat\MinkExtension:
+      goutte: ~
+# Supplied by env variable.
+#      base_url: http://dev-d8lcache.pantheonsite.io/
+    Drupal\DrupalExtension:
+      blackbox: ~
+      api_driver: 'drush'
+      drush:
+# Supplied by env variable.
+#        alias: '@pantheon.d8lcache.dev'

tests/behat/bootstrap/PerformanceHelpers.php

@@ -0,0 +1,133 @@
+<?php
+
+namespace Drupal\LCache\Behat;
+
+use Behat\Behat\Context\Context;
+use Behat\Behat\Context\SnippetAcceptingContext;
+use Behat\MinkExtension\Context\MinkContext;
+use Behat\Behat\Hook\Scope\BeforeScenarioScope;
+
+/**
+ * Define application features from the specific context.
+ */
+class PerformanceHelpers implements Context, SnippetAcceptingContext {
+
+  /** @var \Behat\MinkExtension\Context\MinkContext */
+  private $minkContext;
+
+  /** @BeforeScenario */
+  public function gatherContexts(BeforeScenarioScope $scope)
+  {
+      $environment = $scope->getEnvironment();
+      $this->minkContext = $environment->getContext('Drupal\DrupalExtension\Context\MinkContext');
+  }
+
+  /**
+   * Fills in form field with specified id|name|label|value
+   * Example: When I fill in "admin_password2" with a random string "12" characters long
+   *
+   * @When I fill in :arg1 with a random string :arg2 characters long
+   */
+  public function fillFieldWithRandomString($field, $length)
+  {
+      $this->minkContext->fillField($field, $this->rand_string( $length ));
+  }
+
+  protected function rand_string( $length ) {
+  	$chars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789";
+    $str = '';
+  	$size = strlen( $chars );
+  	for( $i = 0; $i < $length; $i++ ) {
+  		$str .= $chars[ rand( 0, $size - 1 ) ];
+  	}
+
+  	return $str;
+  }
+
+
+  /**
+   * @When I open the links to all homepage posts
+   */
+  public function iOpenTheLinksToAllHomepagePosts()
+  {
+
+    $this->minkContext->visit("/");
+
+    $next_page_exists = TRUE;
+    $next_page_url ='';
+
+    while($next_page_exists) {
+
+      $page = $this->minkContext->getSession()->getPage();
+      $next_page_link = $page->find('css', '.pager__item--next a');
+      //echo $this->minkContext->getSession()->getPage()->find('css', '.pager__items')->getHtml();
+      if ($next_page_link) {
+        $next_page_url = $next_page_link->getAttribute('href');
+      }
+      else {
+        $next_page_exists = FALSE;
+      }
+
+      $this->openAllPostLinksOnASinglePage($page);
+
+      if (!empty($next_page_link)) {
+        $this->minkContext->visit($next_page_url);
+
+        print_r("\n\n");
+        print_r($next_page_url);
+        print_r("\n\n");
+
+        //print_r($this->minkContext->getSession()->getResponseHeaders());
+      }
+    }
+    echo "last page visited was $next_page_url";
+  }
+
+
+  protected function openAllPostLinksOnASinglePage($page) {
+
+    $post_urls = $this->getAllPostURLs($page);
+
+    foreach ($post_urls as $post_url) {
+      $this->minkContext->visit($post_url);
+      //echo "\n";
+      //echo $this->minkContext->getSession()->getPage()->find('css', 'h1.page-title')->getHtml();
+      //echo "\n";
+      //$this->minkContext->printCurrentUrl();
+      //echo "\n";
+      //print_r($this->minkContext->getSession()->getResponseHeaders());
+    }
+
+  }
+
+  protected function getAllPostURLs($page) {
+
+    $post_links = $page->findAll('css', 'article header h2 a');
+
+    $post_urls = [];
+    foreach ($post_links as $post_link) {
+      $post_urls[] =$post_link->getAttribute('href');
+    }
+
+    //print_r("\n\n");
+    //print_r($post_urls[0]);
+    //print_r("\n\n");
+    return $post_urls;
+  }
+
+  /**
+   * @Given I log in as an admin
+   */
+  public function ILogInAsAnAdmin()
+  {
+    $this->minkContext->visit('user');
+    $this->minkContext->fillField('name', getenv('DRUPAL_ADMIN_USERNAME'));
+    $this->minkContext->fillField('pass', getenv('DRUPAL_ADMIN_PASSWORD'));
+    $this->minkContext->pressButton('Log in');
+    //$this->minkContext->printCurrentUrl();
+    $this->minkContext->visit('admin');
+    //$this->minkContext->printCurrentUrl();
+
+  }
+
+}

tests/behat/features/create-node-view-all-nodes.feature

@@ -0,0 +1,32 @@
+Feature: Create node, view all nodes
+
+
+
+  Background:
+    Given I log in as an admin
+
+ @api
+  Scenario: Create node, view all nodes
+
+
+When I visit "node/add/article"
+And I fill in "title[0][value]" with "Test article title"
+And I fill in "title[0][value]" with a random string "12" characters long
+And I press the "Save and publish" button
+
+When I visit "node/add/article"
+And I fill in "title[0][value]" with "Test article title"
+And I fill in "title[0][value]" with a random string "12" characters long
+And I press the "Save and publish" button
+
+When I visit "node/add/article"
+And I fill in "title[0][value]" with "Test article title"
+And I fill in "title[0][value]" with a random string "12" characters long
+And I press the "Save and publish" button
+
+When I visit "node/add/article"
+And I fill in "title[0][value]" with "Test article title"
+And I fill in "title[0][value]" with a random string "12" characters long
+And I press the "Save and publish" button
+
+When I open the links to all homepage posts

tests/behat/features/node-saving.feature

@@ -0,0 +1,11 @@
+Feature: Node saving
+
+  @api
+  Scenario: Node Saving
+    Given I am logged in as a user with the "administrator" role
+    And I visit "/"
+    When I visit "node/add/article"
+    And I fill in "title[0][value]" with "First Test Article"
+    And I press the "Save and publish" button
+    And I visit "/"
+    Then I see the text "First Test Article"

tests/circle-scripts/clone-repo.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+git clone $(terminus site connection-info --field=git_url) $TERMINUS_SITE
+cd $TERMINUS_SITE
+git checkout $TERMINUS_ENV