Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly connect all articles in a snippet to an imported resource #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elpoelma
Copy link
Contributor

@elpoelma elpoelma commented Nov 22, 2024

Overview

This PR adds a utility button to the snippet-editor sidebar which allows you to quickly connect all non-connected articles in a snippet to an imported resource.

  • Button is greyed out if all articles are connected
  • The resource URI is formed as follows: http://example.org/imported-decision-${snippetList.id}

Setup

None

How to test/reproduce

  • Start the frontend
  • Open a snippet which contains articles that are not connected to an imported resource yet
  • Click the connect button + ensure it greys out
  • Ensure all articles are now connected through the http://data.europa.eu/eli/ontology#has_part predicate
  • Save the snippet and go back to it's snippet-list edit page
  • The imported resource should now correctly show up

Challenges/Uncertainties

  • As this is an internal tool, I didn't bother with translations.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check cancel/go-back flows
  • Check database state correct when deleting/updating (especially regarding relationships)
  • changelog
  • npm lint
  • no new deprecations

@elpoelma elpoelma added the internal Version bumps, chores, tooling label Nov 22, 2024
@elpoelma elpoelma self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Version bumps, chores, tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant