GN-4378 Revalidate codelist options list when changing the label

[x-m-el]

Overview

Before only the record you changed would get revalidated by ember-changeset (because of auto-validation of ember-changeset being active). However, the uniqueness depends on more than the changed record.
To fix this, the list of labels is revalidated for uniqueness after every change.

connected issues and PRs:

https://binnenland.atlassian.net/browse/GN-4378

How to test/reproduce

Getting the error before:

1. create a codelist with 2 items and the same label.
2. adjust the label of the item that does not have an error
3. the save button would still not be active, even though everything is valid now.

With this change, you will be able to save in step 3.

Challenges/uncertainties

• ember-changeset does not have a "removeError" function... This is annoying as we add custom errors (that aren't possible with ember-changeset-validation). A workaround is used. PR is open to add this (add #removeError and #removeErrors to Changeset interface adopted-ember-addons/ember-changeset#668), but this will probably take a while to get released.
• the ChangesetList's changeset array does not track properly. The errors get added correctly, but the UI might sometimes not show the error message even if it is present. I did not find any fix, didn't work:
  • using tracked-built-ins
  • rewriting the array after a changes (with this._changesets = [...this._changesets] in ChangesetList)
    This might be because ChangesetList is a separate class?

[elpoelma]

Seems like a good workaround overall, just a comment.