Add workaround to get ember-inspector working on vite builds #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elpoelma
force-pushed
the
tooling/vite-ember-inspector
branch
from
f611caa to
9114d5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a workaround to get the ember-inspector working on vite builds.
It installs (and includes)
loader.js, an AMD loader and then loads the necessary modules which the ember-inspector needs.Once emberjs/ember-inspector#2625 is merged and released, we can remove this workaround.
I realize that this is not an ideal solution (as it adds an AMD loader back), but this currently seems to be the only option to get the ember-inspector working with vite builds.