Open
Conversation
Author
Member
|
感谢 我晚上看下! |
Member
|
感谢贡献,有几个问题需要讨论下~ 关于sdk-infrastructure
如果是为了代码复用,能否: a. 简单一点,就把这些代码放在domain包里呢 b. 如果不行的话,改个名字呢, |
Member
|
(如果打字不好沟通的话,可以约个时间视频会议聊 |
Author
|
@seeflood good idea! 工作日下午怎么样? |
Member
|
@kevinten10 好呀 明天下午?你看几点合适 |
Author
|
要不就先暂定明天下午三点或者四点吧~ |
Member
|
好 |
Author
|
Iam busy at the end of the year. Give me some time to finish the refactoring~ |
Member
|
@kevinten10 hi, is this PR ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi,这里是对原有
runtime-sdk的改动(不包含reactor),我尽力保持所有类路径和使用方式的不变。layer design
Here is the overall design of the modules:
从
runtime-sdk中拆分出了sdk-infrastructure和sdk-domain模块。sdk-infrastructure:
变更介绍
将
runtime-sdk中的基础定义类、工具类、属性类等下沉到sdk-infrastructure层,这将被多种上层实现复用。非兼容的变更点
io.mosn.layotto.v1.domain.ApiProtocol移动到io.mosn.layotto.v1.value.ApiProtocol。sdk-domain包占用,使用value路径sdk-domain:
变更介绍
将标准API的定义剥离到
sdk-domain层,包括请求响应的实体类、接口定义。独立的API定义模块
sdk-domain,将有利于:sdk-domain模块实现dapr的API。注:
sdk-domain仅包含同步调用的api,后续reactor模式的api将放在sdk-domain-rx模块中。变更点
我没有改动原有的API接口和实体类的使用(仅在代码风格上做了统一,以及添加了
toString这样的方法)。不过我新增了
configuration的API entities和API接口(接口方法先注释掉了,后续再添加实现)。故和原有API兼容。
grpc
仍在保留在
runtime-sdk中。