Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collaborator avatar group component #937

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

amitamrutiya
Copy link
Contributor

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

@amitamrutiya amitamrutiya changed the title Zdd collaborator avatar group component Add collaborator avatar group component Feb 24, 2025
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there default color used if a color is not provided by user preferences?

Is this component documented in layer5.io/projects/sistent?

.map(([clientID, user]) => (
<PopupAvatarWrapper
key={clientID}
onClick={() => openInNewTab(`https://${CLOUD_URL}/user/${user.user_id}`)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an example use of this component that can be included here?

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs, test/example use.

Signed-off-by: amitamrutiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants