-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collaborator avatar group component #937
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: amitamrutiya <[email protected]>
Signed-off-by: amitamrutiya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there default color used if a color is not provided by user preferences?
Is this component documented in layer5.io/projects/sistent?
.map(([clientID, user]) => ( | ||
<PopupAvatarWrapper | ||
key={clientID} | ||
onClick={() => openInNewTab(`https://${CLOUD_URL}/user/${user.user_id}`)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an example use of this component that can be included here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing docs, test/example use.
Signed-off-by: amitamrutiya <[email protected]>
Notes for Reviewers
This PR fixes #
Signed commits