-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image validator helper func #471
Conversation
Signed-off-by: sudhanshu dasgupta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A basic URL verification will be helpful, to validate if the url provided is acutally a uri and not a random text/executable script code.
It will also help to skip the effort of trying to load the url if it's invalid.
Signed-off-by: sudhanshu dasgupta <[email protected]>
…o add/image/func
Signed-off-by: sudhanshu dasgupta <[email protected]>
Great comment! |
Co-authored-by: aabidsofi19 <[email protected]> Signed-off-by: Lee Calcote <[email protected]>
…o add/image/func Signed-off-by: sudhanshu dasgupta <[email protected]>
merge conflict... |
I'll offer the suggestion that we close this PR. What do you think, @sudhanshutech? |
Notes for Reviewers
This PR fixes #
Signed commits