Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Image validator helper func #471

Closed
wants to merge 6 commits into from

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Jan 30, 2024

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: sudhanshu dasgupta <[email protected]>
Copy link

@MUzairS15 MUzairS15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A basic URL verification will be helpful, to validate if the url provided is acutally a uri and not a random text/executable script code.
It will also help to skip the effort of trying to load the url if it's invalid.

@leecalcote
Copy link
Member

A basic URL verification will be helpful, to validate if the url provided is acutally a uri and not a random text/executable script code. It will also help to skip the effort of trying to load the url if it's invalid.

Great comment!

@sudhanshutech sudhanshutech added the kind/enhancement Improvement in current feature label Mar 4, 2024
@leecalcote
Copy link
Member

merge conflict...

@leecalcote
Copy link
Member

I'll offer the suggestion that we close this PR. What do you think, @sudhanshutech?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature
Development

Successfully merging this pull request may close these issues.

4 participants