Transfer list component #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Senali <[email protected]>
|
Do we have a theme reference? |
Signed-off-by: Senali <[email protected]>
Not in this package now, the style from whatever theme we're using in Meshery Cloud and Meshery UI will be applied. |
nebula-aac
requested changes
Dec 14, 2023
nebula-aac
reviewed
Dec 14, 2023
| @@ -0,0 +1,73 @@ | |||
| import { Button, Chip, Grid, Paper, Typography } from '@mui/material'; | |||
| import { styled } from '@mui/system'; | |||
There was a problem hiding this comment.
You don't need to use styled from @mui/system, @mui/material also has one.
nebula-aac
reviewed
Dec 14, 2023
| @@ -0,0 +1,246 @@ | |||
| import { KuberneteIcon, LeftArrowIcon, RightArrowIcon, SMPIcon } from '@layer5/sistent-svg'; | |||
| import { Tooltip, Typography } from '@mui/material'; | |||
There was a problem hiding this comment.
Use the imports internally, instead of calling from @mui/material, This will allow us to make changes to the components itself to have it applied across all components.
nebula-aac
reviewed
Dec 14, 2023
nebula-aac
reviewed
Dec 14, 2023
| TransferButton | ||
| } from './style'; | ||
|
|
||
| export const TRANSFER_COMPONET = { |
There was a problem hiding this comment.
This is spelled wrong.
TRANSFER_COMPONENT
nebula-aac
reviewed
Dec 15, 2023
nebula-aac
reviewed
Dec 15, 2023
|
Right Arrow icon PR merged. |
…transfer-list-387 Signed-off-by: Senali <[email protected]>
Signed-off-by: Senali <[email protected]>
Signed-off-by: Senali <[email protected]>
Signed-off-by: Senali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #387
Signed commits