Add Spring animation library package #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
|
@nebula-aac we will required this package as our toolbar components starts working so then i can add this animation later on, |
nebula-aac
requested changes
May 2, 2024
|
not so sure, when need i will make a new pr, for now i am closing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR adds package for react spring animations
For initially we will required this animation for smooth closing an opening for toolbar components and then we can use for any animation we need.
Any other normal css for animation will produce bugs for column and filter to open thats why are using spring for smoothness
Signed commits