-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[component] Tooltip Icon #377
Conversation
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Thanks for the PR, but I know I wasn't exactly specific in what I was looking for in creating a component for this. I have it already done in the Stackblitz I provided which seems to be working at the moment. The one I have is meant to fix the issue with the React.forwardRef so that all the other components don't need to be updated to use this. At least from what I've seen. |
oh okay got it, i made pr i thought it was required for that same quick |
No worries, this PR can be for a generic Tooltip Icon since I think we are using it in Meshery |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're ok to move forward?
No this will needs to be moved to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this component to src
directory out of package
?
Also rename this component as to not confuse with other components that are similar. Namely the one I created beforehand.
I will make this tooltip as the tooltip we use for information across modals |
@sudhanshutech you didn't answer @nebula-aac's question. |
…o tooltip/icom Signed-off-by: sudhanshu dasgupta <[email protected]>
Signed-off-by: sudhanshu dasgupta <[email protected]>
yes, its done now |
Signed-off-by: sudhanshu dasgupta <[email protected]>
Signed-off-by: sudhanshu dasgupta <[email protected]>
@sudhanshutech there are two different tooltips being used in Meshery UI. @iArchitSharma should have recently filed an issue on this that he can link here. Let's consolidate to the better looking of the two, which should be the Sistent tooltip. Hopefully, this is the good-looking tip. |
Link to issue - https://app.clickup.com/t/86cuqu3qm |
thanks @iArchitSharma i will take a look on the task |
Notes for Reviewers
This PR fixes #376
Signed commits