Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[component] Tooltip Icon #377

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #376

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
@nebula-aac
Copy link
Contributor

Thanks for the PR, but I know I wasn't exactly specific in what I was looking for in creating a component for this. I have it already done in the Stackblitz I provided which seems to be working at the moment.

The one I have is meant to fix the issue with the React.forwardRef so that all the other components don't need to be updated to use this. At least from what I've seen.

@sudhanshutech
Copy link
Member Author

oh okay got it, i made pr i thought it was required for that same quick

@nebula-aac
Copy link
Contributor

No worries, this PR can be for a generic Tooltip Icon since I think we are using it in Meshery

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're ok to move forward?

@nebula-aac
Copy link
Contributor

No this will needs to be moved to the src directory

@nebula-aac nebula-aac self-requested a review February 7, 2024 02:46
Copy link
Contributor

@nebula-aac nebula-aac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this component to src directory out of package?

Also rename this component as to not confuse with other components that are similar. Namely the one I created beforehand.

@sudhanshutech
Copy link
Member Author

I will make this tooltip as the tooltip we use for information across modals

@leecalcote
Copy link
Member

I will make this tooltip as the tooltip we use for information across modals

@sudhanshutech you didn't answer @nebula-aac's question.

@sudhanshutech
Copy link
Member Author

I will make this tooltip as the tooltip we use for information across modals

@sudhanshutech you didn't answer @nebula-aac's question.

yes, its done now

Signed-off-by: sudhanshu dasgupta <[email protected]>
Signed-off-by: sudhanshu dasgupta <[email protected]>
@leecalcote leecalcote merged commit 29fd2d0 into layer5io:master Feb 28, 2024
8 checks passed
@leecalcote
Copy link
Member

@sudhanshutech there are two different tooltips being used in Meshery UI.

@iArchitSharma should have recently filed an issue on this that he can link here. Let's consolidate to the better looking of the two, which should be the Sistent tooltip. Hopefully, this is the good-looking tip.

@iArchitSharma
Copy link

Link to issue - https://app.clickup.com/t/86cuqu3qm
@sudhanshutech

@sudhanshutech
Copy link
Member Author

thanks @iArchitSharma i will take a look on the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[components]: Create TooltipIcon
4 participants