Fix Sistent Website build failure #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: coder12git <[email protected]>
github-actions
bot
added
area/docs
coder12git
changed the title
|
cc @leecalcote @aabidsofi19 |
aabidsofi19
requested changes
Nov 7, 2023
| <> | ||
| const Navbar = () => { | ||
| return ( | ||
| <ThemeContext.Consumer> |
There was a problem hiding this comment.
please use useContext than context.consumer . former makes code more readable
site/src/components/Theme/index.js
Outdated
| componentDidMount() { | ||
| // Getting dark mode value from localStorage! | ||
| const lsDark = JSON.parse(localStorage.getItem("dark")) |
There was a problem hiding this comment.
typo , should be isDark
site/src/components/Theme/index.js
Outdated
| window.matchMedia("(prefers-color-scheme: dark)").matches === true | ||
|
|
||
| class ThemeProvider extends React.Component { |
There was a problem hiding this comment.
Please use Functional components
|
Thank you @coder12git , i have added some feedback . |
Signed-off-by: coder12git <[email protected]>
Yes change it to functional in recent push |
…stent into sistent-site-draft
Signed-off-by: coder12git <[email protected]>
|
@aabidsofi19 fixed all the changes requested |
|
Once this is merged, we will need to update the components that do not have a proper export |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #235
Signed commits