-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added integration icons in homepage animation #6025
Added integration icons in homepage animation #6025
Conversation
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit 963b8d6 at: https://67196b9fbcf328af057d2606--layer5.netlify.app |
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit 22b45ef at: https://6719b922e5e76e422360f7dd--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please avoid using lint changes it makes hard to review
@sudhanshutech Got it, thanks I will avoid lint changes in PRs to make reviews easier. Thanks again for the approval. |
Hi @vishalvivekm could you please review this PR and let me know if any changes are needed for merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert lint change, and adhere to project's eslint conventions
Thanks, @Tharanishwaran! |
This is a great idea, @Tharanishwaran. No visitor should ever have the sense that Meshery's integrations are limited. Instead, they should have the sense that there are simply too many to list and scroll. |
Thanks @vishalvivekm I’ll revert the lint changes to match the project's eslint convention. |
Thank you, @leecalcote. |
Please don't use the Helm icon or any other that has such a low contrast with the background (at least in dark mode, it does). |
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit 66dc0af at: https://671bed2381a5f4be54d48938--layer5.netlify.app |
Signed-off-by: Tharanishwaran <[email protected]>
🚀 Preview for commit c623ebf at: https://671bf2ab8a0d53b8887ce3ff--layer5.netlify.app |
Description
This PR fixes #5899
Notes for Reviewers
Screenshots
Signed commits