Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added integration icons in homepage animation #6025

Merged

Conversation

Tharanishwaran
Copy link
Member

@Tharanishwaran Tharanishwaran commented Oct 23, 2024

Description

This PR fixes #5899

Notes for Reviewers

  • The number of integration icons in the homepage animation has been increased to minimize empty spaces.

Screenshots

Screenshot from 2024-10-26 00-30-13

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 23, 2024

🚀 Preview for commit 963b8d6 at: https://67196b9fbcf328af057d2606--layer5.netlify.app

Signed-off-by: Tharanishwaran <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 24, 2024

🚀 Preview for commit 22b45ef at: https://6719b922e5e76e422360f7dd--layer5.netlify.app

Copy link
Member

@sudhanshutech sudhanshutech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please avoid using lint changes it makes hard to review

@Tharanishwaran
Copy link
Member Author

Tharanishwaran commented Oct 24, 2024

@sudhanshutech Got it, thanks I will avoid lint changes in PRs to make reviews easier.

Thanks again for the approval.

@Tharanishwaran
Copy link
Member Author

Tharanishwaran commented Oct 24, 2024

Hi @vishalvivekm could you please review this PR and let me know if any changes are needed for merging?

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert lint change, and adhere to project's eslint conventions

@leecalcote
Copy link
Member

Thanks, @Tharanishwaran!

@leecalcote
Copy link
Member

This is a great idea, @Tharanishwaran. No visitor should ever have the sense that Meshery's integrations are limited. Instead, they should have the sense that there are simply too many to list and scroll.

@Tharanishwaran
Copy link
Member Author

Please revert lint change, and adhere to project's eslint conventions

Thanks @vishalvivekm I’ll revert the lint changes to match the project's eslint convention.

@Tharanishwaran
Copy link
Member Author

This is a great idea, @Tharanishwaran. No visitor should ever have the sense that Meshery's integrations are limited. Instead, they should have the sense that there are simply too many to list and scroll.

Thank you, @leecalcote.

@ritzorama
Copy link

Please don't use the Helm icon or any other that has such a low contrast with the background (at least in dark mode, it does).

Signed-off-by: Tharanishwaran <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 25, 2024

🚀 Preview for commit 66dc0af at: https://671bed2381a5f4be54d48938--layer5.netlify.app

Signed-off-by: Tharanishwaran <[email protected]>
@l5io
Copy link
Contributor

l5io commented Oct 25, 2024

🚀 Preview for commit c623ebf at: https://671bf2ab8a0d53b8887ce3ff--layer5.netlify.app

@sudhanshutech sudhanshutech merged commit e5e04f1 into layer5io:master Oct 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Increase number of Integration icons in Homepage animation to prevent blank spaces
6 participants