Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the table #5782

Closed
wants to merge 2 commits into from
Closed

Conversation

NareshBiradar1
Copy link

@NareshBiradar1 NareshBiradar1 commented Aug 4, 2024

Description

This PR fixes #5671

Description

This pull request adds a ResponsiveDataTable component to the Sistent project. It introduces a table with sample data and columns designed to be responsive and adaptable to different screen sizes.

Key Changes:

  • Added Columns and Sample Data: Defined columns for displaying name, ISO code, population, size, and density of various countries.
  • Component Integration: Integrated the ResponsiveDataTable component into the SistentComponentsPage, showcasing how to use it with the provided sample data.
  • Column Visibility Control: Included a columnVisibility object to manage the visibility of columns.
  • Update Function: Added a placeholder updateColumns function to demonstrate how column updates can be handled.

Components Updated:

  • SistentComponentsPage: Added the ResponsiveDataTable component and updated the component structure.

Note: The ResponsiveDataTable component is currently commented out but can be enabled by uncommenting the relevant lines of code.

Signed-off-by: Naresh Biradar <[email protected]>
@github-actions github-actions bot added the area/projects An issue relating to Layer5 initiatives (projects) label Aug 4, 2024
Signed-off-by: Naresh Biradar <[email protected]>
@l5io
Copy link
Contributor

l5io commented Aug 4, 2024

🚀 Preview for commit 39373b5 at: https://66afc9ed9e097ee72fed7c3b--layer5.netlify.app

@Ashparshp
Copy link
Contributor

@NareshBiradar1 Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes. The call is scheduled for Monday at 5:30 PM IST.

@sudhanshutech
Copy link
Member

@NareshBiradar1 why its commented out ?

@sudhanshutech
Copy link
Member

sudhanshutech commented Aug 5, 2024

@NareshBiradar1 this table is need to be represented as a sistent custom component. It will added here https://layer5.io/projects/sistent/components. Same as other component there will a card of Table. See the other components for reference and implementation

@sudhanshutech
Copy link
Member

This is not ready to merge now...

@sudhanshutech
Copy link
Member

@NareshBiradar1 ?

@Ashparshp
Copy link
Contributor

@NareshBiradar1, please respond when you get some time.

@Ashparshp
Copy link
Contributor

@NareshBiradar1, any luck?

@Ashparshp
Copy link
Contributor

@vishalvivekm, as we haven't heard back from @NareshBiradar1 we can close this PR?

@vishalvivekm
Copy link
Member

@vishalvivekm, as we haven't heard back from @NareshBiradar1 we can close this PR?

Yes, please make a call for volunteers on next websites call @Ashparshp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/projects An issue relating to Layer5 initiatives (projects) pr/do-not-merge
Development

Successfully merging this pull request may close these issues.

[sistent] Add Data-tables component in sistent project
5 participants